Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused public APIs in share plugin #116992

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Remove unused public APIs in share plugin #116992

merged 3 commits into from
Nov 3, 2021

Conversation

stacey-gammon
Copy link
Contributor

@stacey-gammon stacey-gammon commented Nov 1, 2021 •
edited
Loading

Removes more unused public APIs from the Share plugin. The public migrate function was never used and that class is deprecated anyhow.

@stacey-gammon stacey-gammon force-pushed the 2021-11-01-remove-unused-public-APIs branch from 4b4e951 to 120df34 Compare November 2, 2021 12:29
@stacey-gammon stacey-gammon added release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Nov 2, 2021
@stacey-gammon stacey-gammon marked this pull request as ready for review November 2, 2021 14:32
@stacey-gammon stacey-gammon requested a review from a team as a code owner November 2, 2021 14:32
@stacey-gammon stacey-gammon force-pushed the 2021-11-01-remove-unused-public-APIs branch from 120df34 to 2ed4bda Compare November 2, 2021 14:32
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
share 65 64 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
share 84 79 -5

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
share 53.8KB 53.2KB -581.0B
Unknown metric groups

API count

id before after diff
share 137 132 -5

History

  • 💚 Build #3592 succeeded 120df34f406f6addf1a188fcab2bcb724b8eaaeb
  • 💔 Build #3469 failed 4b4e95178f20143ce1ef81e753f5b13ce3f041bf
  • 💔 Build #3295 failed ad3f3077e79dfd3497b2e8b791aa911daa4e661f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tsullivan
tsullivan approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stacey-gammon stacey-gammon merged commit d38f488 into elastic:main Nov 3, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 116992 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 5, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 116992 or prevent reminders by adding the backport:skip label.

@stacey-gammon stacey-gammon added the backport:skip This commit does not require backporting label Nov 8, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan approved these changes

@vadimkibana vadimkibana Awaiting requested review from vadimkibana

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stacey-gammon @kibanamachine @tsullivan